Code review consists of manual inspection, discussion, and judgment of source code by developers other than the code's author. Due to discussions around competing ideas and group decision-making processes, interpersonal conflicts during code reviews are expected. This study systematically investigates how developers perceive code review conflicts and addresses interpersonal conflicts during code reviews as a theoretical construct. Through the thematic analysis of interviews conducted with 22 developers, we confirm that conflicts during code reviews are commonplace, anticipated and seen as normal by developers. Even though conflicts do happen and carry a negative impact for the review, conflicts-if resolved constructively-can also create value and bring improvement. Moreover, the analysis provided insights on how strongly conflicts during code review and its context (i.e., code, developer, team, organization) are intertwined. Finally, there are aspects specific to code review conflicts that call for the research and application of customized conflict resolution and management techniques, some of which are discussed in this paper. Data and material: https://doi.org/10.5281/zenodo.5848794
翻译:守则审查包括由守则作者以外的开发者手工检查、讨论和判断源代码。由于围绕相互竞争的想法和团体决策进程进行的讨论,预期守则审查期间会发生人与人之间的冲突。本研究系统调查开发者如何看待守则审查冲突,并在守则审查期间作为一个理论构思处理人与人之间的冲突。通过对与22个开发者的访谈进行专题分析,我们确认守则审查期间的冲突是常见的、预期的和开发者认为是正常的。即使冲突确实发生,对审查有负面影响,但冲突-如果建设性地解决,也会创造价值并带来改善。此外,分析还揭示了守则审查期间的冲突及其背景(即守则、开发者、团队、组织)是如何相互交织的。最后,守则审查冲突的某些方面要求研究和应用定制的冲突解决和管理技术,其中一些在本文中讨论。数据和材料:https://doi.org/10.5281/zenodo58494。